Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Column name mapping in missing left/right #12

Merged
merged 11 commits into from
Nov 7, 2024
Merged

fix: Column name mapping in missing left/right #12

merged 11 commits into from
Nov 7, 2024

Conversation

MariusMerkleQC
Copy link
Contributor

@MariusMerkleQC MariusMerkleQC commented Nov 6, 2024 •
edited
Loading

Description

Solves #7

Tasks

  • Extend Names class with a name_mapping attribute
  • Adjust tests

Review

  • Feedback:
  • Number of required reviews: 1, @borchero

@MariusMerkleQC MariusMerkleQC self-assigned this Nov 6, 2024
@github-actions github-actions bot added the fix label Nov 6, 2024
@MariusMerkleQC MariusMerkleQC marked this pull request as ready for review November 6, 2024 12:43
borchero
borchero approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@borchero borchero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care, lgtm!

sqlcompyre/results/names.py Show resolved Hide resolved
tests/analysis/table_comparison/test_column_matching.py Show resolved Hide resolved
@borchero borchero linked an issue Nov 7, 2024 that may be closed by this pull request
Column name mapping ignored for missing in left/right #7
Closed
@borchero borchero merged commit e5f2484 into main Nov 7, 2024
9 checks passed
@borchero borchero deleted the ignore branch November 7, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borchero borchero borchero approved these changes

Assignees

@MariusMerkleQC MariusMerkleQC

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column name mapping ignored for missing in left/right
2 participants
@MariusMerkleQC @borchero