Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column name mapping ignored for missing in left/right #7

Closed
MariusMerkleQC opened this issue Sep 30, 2024 · 0 comments · Fixed by #12
Closed

Column name mapping ignored for missing in left/right #7

MariusMerkleQC opened this issue Sep 30, 2024 · 0 comments · Fixed by #12

Comments

@MariusMerkleQC
Copy link
Contributor

When I provide a column_name_mapping to compare_tables(), it uses the mapping to compare the values in the respective columns and fills the section "Column Matches" properly. For example, if column_name_mapping = {"a": "b"}, the values of column "a" in the left table are compared with the values of column "b" in the right table.

However, it still fills the lists "Missing in left: ["b"]" and "Missing in right: ["a"]". I think it would be more intuitive for a user to remove the column names from these missing lists. If I provide a column_name_mapping, I always remove the values contained in the mapping from these lists, to see which columns are actually missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant