Fix dropdown gallery filtering #208
Conversation
jukent
requested review from
dopplershift and
ktyle
and removed request for
a team
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
| @@ -10,21 +10,16 @@ def main(app): | |||
|
|
|||
| title = "Cookbooks Gallery" | |||
|
|
|||
| subtext = "" | |||
There was a problem hiding this comment.
Just wondering what's the motivation for removing this and putting the subtext in as HTML?
There was a problem hiding this comment.
I can put that back, it was an extraneous edit made in the beginning of wrestling with the gallery generator being broken. I was probably trying to track down a broken extension and never undid it.
There was a problem hiding this comment.
That makes sense. Yes, if you can revert that part back, I think it will be easier to maintain the subtext content if it stays in its own markdown file.
There was a problem hiding this comment.
Fixed. I'll deal with making the dropdown buttons prettier on Monday. Have a good weekend!
There was a problem hiding this comment.
I'm not familiar with javascript or css so I can't review all the details, but it looks good to me. I tested out the functionality of the filters in the preview and everything seems to working. Hooray for that! Nice work @jukent!
|
This PR closes #207 |
Part of ProjectPythia/projectpythia.github.io#419
Closing #199 in favor of this due to merge conflict weirdness
Corrects sphinx dropdown call, HTML, CSS, and Javascript for filtering.
CSS on dropdowns can still be tweaked.