Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookbook gallery filters broken #207

Closed
clyne opened this issue Jun 6, 2024 · 6 comments · Fixed by #208
Closed

cookbook gallery filters broken #207

clyne opened this issue Jun 6, 2024 · 6 comments · Fixed by #208
Labels
infrastructure Infrastructure related issue

Comments

@clyne
Copy link
Contributor

clyne commented Jun 6, 2024

The Cookbook Gallery filters do not seem to be operational. Navigate to the gallery. Click on either of the filters, Domain or Package. Nothing happens.

@clyne clyne added the infrastructure Infrastructure related issue label Jun 6, 2024
@brian-rose
Copy link
Member

I think this is being worked on in #199

@brian-rose
Copy link
Member

Overall issue is being tracked at ProjectPythia/projectpythia.github.io#419

@brian-rose brian-rose linked a pull request Jun 7, 2024 that will close this issue
@jukent
Copy link
Contributor

jukent commented Jun 7, 2024

New PR to fix this is in #208

Functionality is back, but I was forced to use new Sphinx classes and so the styling isn't pretty.

@brian-rose
Copy link
Member

Functionality is back, but I was forced to use new Sphinx classes and so the styling isn't pretty.

With the cookoff next week and many people looking at the gallery and trying to figure out what tags they want to use, I think that functionality >> prettiness.

@jukent assuming #208 gets merged, I think it would be helpful to open an issue describing what you learned, and what's left to do.

@jukent
Copy link
Contributor

jukent commented Jun 7, 2024

Okay. It can be merged today as is if you approve, and I'll open a new issue for improving the styling. This same fix needs to be made in the resource gallery.

I'm OOO today so I can work on that on Monday. I'll document the changes better for anyone who wants to learn/in case something breaks again.

@brian-rose
Copy link
Member

Sounds good. I'll merge #208 now and open a placeholder issue about the styling and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants