Multiple options for configuring RavenDB client certificate #4767
+89
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
changed the title
danielmarbach
approved these changes
Jan 31, 2025
src/ServiceControl.Audit.Persistence.RavenDB/ServerConfiguration.cs
Outdated
Show resolved
Hide resolved
| public class ServerConfiguration | ||
| using ServiceControl.RavenDB; | ||
|
|
||
| public class ServerConfiguration : IRavenClientCertificateInfo |
There was a problem hiding this comment.
Please don't hesitate to ignore. I do not find the interface is particularly helpful. We could also just have a record/class encapsulating these settings that is then passed to the reader code
There was a problem hiding this comment.
Yeah I was lazy and didn't want to do extra mapping.
| { | ||
| try | ||
| { | ||
| var bytes = Convert.FromBase64String(certInfo.ClientCertificateBase64); |
There was a problem hiding this comment.
I agree, it is probably better to throw when the values are not valid instead of falling back to reading the other variables
DavidBoike
force-pushed
the
cert-options
branch
from
71725b3 to
d7dd734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following configuration options as environment variables for connecting to external RavenDB instances, generally for use when deployed as a container:
RAVENDB_CLIENTCERTIFICATEPATH: Provide a path to the client certificate, for example, to a path loaded in a mounted secrets volume.RAVENDB_CLIENTCERTIFICATEBASE64: Provide the client certificate as a Base64-encoded string.RAVENDB_CLIENTCERTIFICATEPASSWORD: If using a password-protected *.pfx certificate, supply the password to read it. If using a non-protected certificate, do not include this option.If the certificate path or Base64 options are not used, the app will still look for a certificate in a static path in the application root. When deployed as a container, this path is
/app/raven-client-certificate.pfx.