Changes from review

Particular · Jan 31, 2025 · d7dd734 · d7dd734
1 parent fe8daaf
commit d7dd734
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/ServiceControl.Audit.Persistence.RavenDB/ServerConfiguration.cs b/src/ServiceControl.Audit.Persistence.RavenDB/ServerConfiguration.cs
@@ -20,9 +20,9 @@ public ServerConfiguration(string dbPath, string serverUrl, string logPath, stri
         }
 
         public string ConnectionString { get; }
-        public string ClientCertificatePath { get; internal set; }
-        public string ClientCertificateBase64 { get; internal set; }
-        public string ClientCertificatePassword { get; internal set; }
+        public string ClientCertificatePath { get; set; }
+        public string ClientCertificateBase64 { get; set; }
+        public string ClientCertificatePassword { get; set; }
         public bool UseEmbeddedServer { get; }
         public string DbPath { get; internal set; } //Setter for ATT only
         public string ServerUrl { get; }

diff --git a/src/ServiceControl.RavenDB/RavenClientCertificate.cs b/src/ServiceControl.RavenDB/RavenClientCertificate.cs
@@ -25,6 +25,10 @@ public static class RavenClientCertificate
 
         if (certInfo.ClientCertificatePath is not null)
         {
+            if (!File.Exists(certInfo.ClientCertificatePath))
+            {
+                throw new Exception("Could not read the RavenDB client certificate from the supplied path because no file was found.");
+            }
             return new X509Certificate2(certInfo.ClientCertificatePath, certInfo.ClientCertificatePassword);
         }