Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the normalization of the timestamps in preprocessing #433

Merged
merged 11 commits into from
Jan 27, 2025

Conversation

tizianoGuadagnino
Copy link
Collaborator

Motivation

The user or a dataloader should not handle timestamp normalization; this should be part of our pipeline. My opinion is that our system should process the data as raw as possible without requiring external manipulations. Furthermore, with this change, we can remove potential sources of errors as the user might not necessarily be aware that timestamps need to be in the range $[0, 1]$.

This PR

Introduction of a timestamp normalization step within the Preprocessor. This computation is performed just if deskew=True and timestamps are not empty. As a result, timestamps normalization is not required anymore in the generic and ROS-based dataloaders (mcap and rosbag through the tools/point_cloud2.py file).

@benemer benemer merged commit 77dd5e5 into main Jan 27, 2025
21 checks passed
@benemer benemer deleted the tiziano/normalize_timestamps_in_preprocessing branch January 27, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants