Move the normalization of the timestamps in preprocessing #433
+9
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The user or a dataloader should not handle timestamp normalization; this should be part of our pipeline. My opinion is that our system should process the data as raw as possible without requiring external manipulations. Furthermore, with this change, we can remove potential sources of errors as the user might not necessarily be aware that timestamps need to be in the range$[0, 1]$ .
This PR
Introduction of a timestamp normalization step within the
Preprocessor
. This computation is performed just ifdeskew=True
andtimestamps
are not empty. As a result, timestamps normalization is not required anymore in thegeneric
and ROS-based dataloaders (mcap
androsbag
through thetools/point_cloud2.py
file).