Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first set of patches #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

first set of patches #6

wants to merge 9 commits into from

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    781705a View commit details
    Browse the repository at this point in the history
  2. Building the 3.30 release of OpenDDS

    What is the latest release version
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0887733 View commit details
    Browse the repository at this point in the history
  3. changelog: fix Lintian warnings 'wrong-bug-number-in-closes' and 'cha…

    …ngelog-is-dh_make-template'
    
    Probably a lefover of the generated Changelog template with the Debian
    Helper tools.
    
    W: opendds: wrong-bug-number-in-closes l3:#nnnn
    N:
    N:    Bug numbers can only contain digits.
    N:
    N:    Refer to Debian Policy Manual section 4.4 (Debian changelog:
    N:    debian/changelog) for details.
    N:
    N:    Severity: warning
    N:
    N:    Check: debian/changelog
    
    E: opendds: changelog-is-dh_make-template
    N:
    N:    The changelog file has an instruction left by dh_make, which has not
    N:    been removed. Example:
    N:
    N:      * Initial release (Closes: #nnnn)  <nnnn is the bug number of your ITP>
    N:
    N:    The "<... is the bug number ...>" part has not been removed from the
    N:    changelog.
    N:
    N:    Severity: error
    N:
    N:    Check: debian/changelog
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b426f9a View commit details
    Browse the repository at this point in the history
  4. Use the default ace release of the OpenDDS configure script.

    The traceability when using the configure option `--ace-github-latests` is less.
    I assume the deb files will not be used of development or regression suites.
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b47246e View commit details
    Browse the repository at this point in the history
  5. lintian: override the missing of the man pages

    W: opendds: binary-without-manpage usr/bin/DCPSInfoRepo
    N:
    N:    Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should
    N:    have a manual page
    N:
    N:    Note that though the man program has the capability to check for several
    N:    program names in the NAMES section, each of these programs should have
    N:    its own manual page (a symbolic link to the appropriate manual page is
    N:    sufficient) because other manual page viewers such as xman or tkman
    N:    don't support this.
    N:
    N:    If the name of the man page differs from the binary by case, man may be
    N:    able to find it anyway; however, it is still best practice to make the
    N:    case of the man page match the case of the binary.
    N:
    N:    If the man pages are provided by another package on which this package
    N:    depends, Lintian may not be able to determine that man pages are
    N:    available. In this case, after confirming that all binaries do have man
    N:    pages after this package and its dependencies are installed, please add
    N:    a Lintian override.
    N:
    N:    Refer to Debian Policy Manual section 12.1 (Manual pages) for details.
    N:
    N:    Severity: warning
    N:
    N:    Check: documentation/man
    N:
    W: opendds: binary-without-manpage usr/bin/ace_gperf
    W: opendds: binary-without-manpage usr/bin/inspect
    W: opendds: binary-without-manpage usr/bin/opendds_idl
    W: opendds: binary-without-manpage usr/bin/tao_idl
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    631761b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. github: changed the working directory from OpenDDS to opendss-VERSION

    To fix the warning:
    dpkg-source: warning: source directory 'OpenDDS' is not <sourcepackage>-<upstreamversion> 'opendds-3.30'
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    e9f11d6 View commit details
    Browse the repository at this point in the history
  2. Lintian: removed pedantic (for now)

    From the man page of lintian:
      Pedantic tags are Lintian at its most pickiest and include checks for particular Debian packaging styles and checks that many people disagree with.
      Expect false positives and Lintian tags that you don't consider useful if you use this option.
      Adding overrides for pedantic tags is probably not worth the effort.
    
    For now this seems to be a huge overkill.
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    046df91 View commit details
    Browse the repository at this point in the history
  3. github action: allow the lintian step to fail.

    For now this seems to be ok.
    There is an result (deb).
    And for now there is not yet the intention to upstream this to Debian.
    
    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    570719c View commit details
    Browse the repository at this point in the history
  4. github: using artifacts

    Signed-off-by: Jan Vermaete <[email protected]>
    vermaete committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    458021f View commit details
    Browse the repository at this point in the history