first set of patches #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Vermaete <[email protected]>
What is the latest release version Signed-off-by: Jan Vermaete <[email protected]>
…ngelog-is-dh_make-template' Probably a lefover of the generated Changelog template with the Debian Helper tools. W: opendds: wrong-bug-number-in-closes l3:#nnnn N: N: Bug numbers can only contain digits. N: N: Refer to Debian Policy Manual section 4.4 (Debian changelog: N: debian/changelog) for details. N: N: Severity: warning N: N: Check: debian/changelog E: opendds: changelog-is-dh_make-template N: N: The changelog file has an instruction left by dh_make, which has not N: been removed. Example: N: N: * Initial release (Closes: #nnnn) <nnnn is the bug number of your ITP> N: N: The "<... is the bug number ...>" part has not been removed from the N: changelog. N: N: Severity: error N: N: Check: debian/changelog Signed-off-by: Jan Vermaete <[email protected]>
The traceability when using the configure option `--ace-github-latests` is less. I assume the deb files will not be used of development or regression suites. Signed-off-by: Jan Vermaete <[email protected]>
W: opendds: binary-without-manpage usr/bin/DCPSInfoRepo N: N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should N: have a manual page N: N: Note that though the man program has the capability to check for several N: program names in the NAMES section, each of these programs should have N: its own manual page (a symbolic link to the appropriate manual page is N: sufficient) because other manual page viewers such as xman or tkman N: don't support this. N: N: If the name of the man page differs from the binary by case, man may be N: able to find it anyway; however, it is still best practice to make the N: case of the man page match the case of the binary. N: N: If the man pages are provided by another package on which this package N: depends, Lintian may not be able to determine that man pages are N: available. In this case, after confirming that all binaries do have man N: pages after this package and its dependencies are installed, please add N: a Lintian override. N: N: Refer to Debian Policy Manual section 12.1 (Manual pages) for details. N: N: Severity: warning N: N: Check: documentation/man N: W: opendds: binary-without-manpage usr/bin/ace_gperf W: opendds: binary-without-manpage usr/bin/inspect W: opendds: binary-without-manpage usr/bin/opendds_idl W: opendds: binary-without-manpage usr/bin/tao_idl Signed-off-by: Jan Vermaete <[email protected]>
To fix the warning: dpkg-source: warning: source directory 'OpenDDS' is not <sourcepackage>-<upstreamversion> 'opendds-3.30' Signed-off-by: Jan Vermaete <[email protected]>
From the man page of lintian: Pedantic tags are Lintian at its most pickiest and include checks for particular Debian packaging styles and checks that many people disagree with. Expect false positives and Lintian tags that you don't consider useful if you use this option. Adding overrides for pedantic tags is probably not worth the effort. For now this seems to be a huge overkill. Signed-off-by: Jan Vermaete <[email protected]>
For now this seems to be ok. There is an result (deb). And for now there is not yet the intention to upstream this to Debian. Signed-off-by: Jan Vermaete <[email protected]>
vermaete
force-pushed
the
master
branch
2 times, most recently
from
a9f962c
to
14c6fa3
Compare
Signed-off-by: Jan Vermaete <[email protected]>
|
PyOpenDDS depends on this being built with master, so it can't be changed by itself. |
| repository: 'objectcomputing/OpenDDS' | ||
| path: OpenDDS | ||
| repository: 'OpenDDS/OpenDDS' | ||
| path: opendds-3.30 |
There was a problem hiding this comment.
Why a hard-coded path like this?
There was a problem hiding this comment.
@iguessthislldo It seems to be another rule of Debian. It was fixing this warning
dpkg-source: warning: source directory 'OpenDDS' is not - 'opendds-3.30'
And I assume it is to create the archive of the source code.
There was a problem hiding this comment.
Well, I wasn't yet their to put the version into a variable.
I'm not sure if I follow. What's the link between (a) attempting to create a Debian package of OpenDDS and (b) a Python package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
All other changes are rather minor.
TODO: