Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP]helpdesk_mgmt: simplify email templates #644

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

PicchiSeba
Copy link

@PicchiSeba PicchiSeba commented Oct 21, 2024

Forward-ports #467 which itself partially forward-ported 98e5ef7 and dfbc369 from 12.0 to 14.0

@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch 2 times, most recently from 71ce9a6 to a582bc6 Compare October 21, 2024 11:57
@PicchiSeba PicchiSeba marked this pull request as draft October 21, 2024 12:08
@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch 3 times, most recently from 4628224 to 3761007 Compare October 21, 2024 13:16
@PicchiSeba PicchiSeba marked this pull request as ready for review October 21, 2024 13:22
@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch 2 times, most recently from 463cb24 to 8a1fc5e Compare October 21, 2024 13:38
@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch from 8a1fc5e to 2852874 Compare November 25, 2024 08:34
@PicchiSeba
Copy link
Author

I just rebased because of a conflict arising from the merge of #643

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unrelated commit, and the fw-port seems done without checking.

helpdesk_mgmt/controllers/main.py Outdated Show resolved Hide resolved
helpdesk_mgmt/data/helpdesk_data.xml Outdated Show resolved Hide resolved
helpdesk_mgmt/data/helpdesk_data.xml Outdated Show resolved Hide resolved
@PicchiSeba
Copy link
Author

PicchiSeba commented Nov 26, 2024

I removed the unrelated commit, the new email template (will do another PR for that) and the stage_id forced assignment in the controller. I also converted the email templates to the 16.0 format.

Do you see any other critical issue?

@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch from fc7d3f4 to d0983db Compare November 26, 2024 09:30
helpdesk_mgmt/tests/test_helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/tests/test_helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
@aleuffre
Copy link

I see 3 different purposes to this PR

  • Refactoring email templates (LGTM on that front)
  • Improving how access to tickets is handled for portal users (LGTM on that front too, and it's closely related)
  • Hardcoding sending an email on ticket creation no matter what (I have some question, and perhaps this could be split in a different PR?)

@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch 2 times, most recently from 2bdd3e3 to 7c4cc4b Compare November 26, 2024 13:00
@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch 2 times, most recently from a513d1e to fd8fba7 Compare November 26, 2024 13:37
eLBati and others added 3 commits December 4, 2024 17:43
- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
@PicchiSeba PicchiSeba force-pushed the 16.0-simplify-email-templates branch from fd8fba7 to 60bfad7 Compare December 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants