Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] helpdesk_product #520

Merged
merged 9 commits into from
Apr 8, 2024
Merged

[16.0][ADD] helpdesk_product #520

merged 9 commits into from
Apr 8, 2024

Conversation

MariaBForgeFlow
Copy link
Contributor

This module adds the option to select product in the helpdesk tickets.

@ForgeFlow

@MariaBForgeFlow MariaBForgeFlow force-pushed the 16.0-add-helpdesk_product branch from d3b280a to ad10a10 Compare October 31, 2023 10:30
dalonsod
dalonsod suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mariadforgeflow thanks for the contribution!

See comments, and also and not blocking, I'd suggest adding a product flag (in template) and/or category that indicates whether a product is available for tickets, so some product could be excluded for this functionality if needed.

helpdesk_product/__manifest__.py Outdated
"license": "AGPL-3",
"category": "After-Sales",
"website": "https://github.com/OCA/helpdesk",
"depends": ["helpdesk_mgmt", "sale_management"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is needed such dependency, shoudn't be product addon instead enough?

helpdesk_product/views/helpdesk_ticket_view.xml
<field name="user_id" position="after">
<field name="product_id" />
</field>
</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add some shortcuts:

  • Filter for tickets with product.
  • Group by product

@MariaBForgeFlow MariaBForgeFlow force-pushed the 16.0-add-helpdesk_product branch from 820a8c3 to ad10a10 Compare November 7, 2023 14:00
@MariaBForgeFlow
Copy link
Contributor Author

Hello @dalonsod

I have modified the module to include the following :

  • Option to make certain products unavailable for tickets
  • Filter for tickets which contain associated products
  • Group tickets by product

I have also changed the module's dependencies so that it depends on "product" instead of "sale_management".

dalonsod
dalonsod approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat 👍
See minor comments anyway. And I only miss row things: a "Products enabled for helpdesk" menu for Helpdesk Managers, like e.g. e-commerce enabled products, and some demo data, but they're not blocking IMO.

helpdesk_product/views/helpdesk_ticket_view.xml Outdated
<filter
string="Product Related"
name="product_filter"
domain="['!', ('product_id', '!=', '' )]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler domain IMO:

Suggested change
domain="['!', ('product_id', '!=', '' )]"
domain="[('product_id', '!=', False)]"

helpdesk_product/views/helpdesk_ticket_view.xml Outdated
<field name="inherit_id" ref="helpdesk_mgmt.ticket_view_tree" />
<field name="arch" type="xml">
<field name="user_id" position="after">
<field name="product_id" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it optional?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024
@MariaBForgeFlow
Copy link
Contributor Author

Tested on runboat 👍 See minor comments anyway. And I only miss row things: a "Products enabled for helpdesk" menu for Helpdesk Managers, like e.g. e-commerce enabled products, and some demo data, but they're not blocking IMO.

Hello David,

I don't quite understand what you mean by having a "Products enabled for helpdesk" menu. Do you mean adding a filter on the product search view to search by products that are enabled for helpdesk?

@dalonsod
Copy link
Contributor

I mean something like this:

imagen

Adding a shortcut to products management within Helpdesk app like e-commerce does.

@MariaBForgeFlow
Copy link
Contributor Author

I will look into it, thank you.

@MariaBForgeFlow MariaBForgeFlow force-pushed the 16.0-add-helpdesk_product branch from ef9d07e to 357bfa3 Compare March 13, 2024 15:11
@MariaBForgeFlow
Copy link
Contributor Author

Hello @dalonsod

I added a menu to the products that are available for helpdesk tickets on the Helpdesk application so that they can be accessed from Helpdesk. Please let me know if there's any other functionality you find missing.

@dalonsod
Copy link
Contributor

👍

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024
DavidJForgeFlow
DavidJForgeFlow approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

flotho
flotho reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributoin.

Regarding the technical everything looks fine but I didn't understood the use case behing this module.
Any chance to have an explanation of the business you're expecting with this module ?
Regards

@MariaBForgeFlow
Copy link
Contributor Author

Thanks for the contributoin.

Regarding the technical everything looks fine but I didn't understood the use case behing this module. Any chance to have an explanation of the business you're expecting with this module ? Regards

Hello Florent,

This module will allow helpdesk users to link a product on a helpdesk ticket to the product's record. One example of how this can be useful is for retail companies, as they might receive complaints from customers regarding specific products, and linking the product on the helpdesk ticket will provide more information to the helpdesk user.
Please let me know if there's anything else I can clarify.

@JordiBForgeFlow
Copy link
Member

@dalonsod Can you merge this one?

@dalonsod
Copy link
Contributor

dalonsod commented Apr 8, 2024

I'm afraid I can't. I have not such access level in this repo 😅

@DarioLodeiros
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-520-by-DarioLodeiros-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4302c06 into OCA:16.0 Apr 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aae9b8a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho left review comments

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

@dalonsod dalonsod dalonsod approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MariaBForgeFlow @dalonsod @OCA-git-bot @JordiBForgeFlow @DarioLodeiros @flotho @DavidJForgeFlow