Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove allow_empty from DSL v2 #693

Merged
merged 1 commit into from
Dec 4, 2023
Merged

remove allow_empty from DSL v2 #693

merged 1 commit into from
Dec 4, 2023

Conversation

OmarTawfik
Copy link
Contributor

It was already removed from grammar. We don't want to emit useless parents. Their references should be optional instead.

@OmarTawfik OmarTawfik requested a review from a team as a code owner December 4, 2023 15:13
@OmarTawfik OmarTawfik enabled auto-merge December 4, 2023 15:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 260e18e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik
remove allow_empty from DSL v2
260e18e 
It was already removed from grammar. We don't want to emit useless parents. Their references should be optional instead.
Xanewok
Xanewok approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for now; we can re-add it later, if we need. Thanks!

@OmarTawfik OmarTawfik added this pull request to the merge queue Dec 4, 2023
Merged via the queue into NomicFoundation:main with commit 6c31653 Dec 4, 2023
1 check passed
@OmarTawfik OmarTawfik deleted the remove-allow-empty branch December 4, 2023 20:02
@OmarTawfik OmarTawfik mentioned this pull request Dec 5, 2023
Closed
14 tasks
@OmarTawfik OmarTawfik mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok