Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back allow_empty in CST containers #814

Closed
OmarTawfik opened this issue Feb 15, 2024 · 0 comments · Fixed by #870
Closed

Bring back allow_empty in CST containers #814

OmarTawfik opened this issue Feb 15, 2024 · 0 comments · Fixed by #870
Assignees
@OmarTawfik

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Feb 15, 2024 •
edited
Loading

It was decided to revert #693, as having the empty parents in the tree is useful for both the AST types and Graph Queries to only need to handle non-nullable fields.

  • Bring back allow_empty in both RepeatedItem and SeparatedItem (default false).
  • In validation, ban referencing Separated/Repeated from an optional field, and convert all violations from (Foo+)? to Foo*.
@OmarTawfik OmarTawfik converted this from a draft issue Feb 15, 2024
@OmarTawfik OmarTawfik mentioned this issue Feb 15, 2024
Closed
@OmarTawfik OmarTawfik moved this to ⏳ Todo in Slang - 2024 H1 Feb 15, 2024
@OmarTawfik OmarTawfik self-assigned this Feb 20, 2024
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 29, 2024
@OmarTawfik
bring back allow_empty to DSL
2159c63 
Closes NomicFoundation#814
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 29, 2024
@OmarTawfik
bring back allow_empty to DSL
f9cb77c 
Closes NomicFoundation#814
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Feb 29, 2024
@OmarTawfik
bring back allow_empty to DSL
c9bad5d 
Closes NomicFoundation#814
OmarTawfik added a commit to OmarTawfik-forks/slang that referenced this issue Mar 1, 2024
@OmarTawfik
bring back allow_empty to DSL
33e7b13 
Closes NomicFoundation#814
@OmarTawfik OmarTawfik mentioned this issue Mar 1, 2024
Merged
@OmarTawfik OmarTawfik moved this from ⏳ Todo to 🔄 In Progress in Slang - 2024 H1 Mar 1, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2024
@OmarTawfik
bring back allow_empty to DSL (#870)
b1611d4 
Closes #814
@github-project-automation github-project-automation bot moved this from 🔄 In Progress to ✅ Done in Slang - 2024 H1 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
None yet
Projects
No open projects
Slang - 2024 H1
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bring back allow_empty to DSL OmarTawfik-forks/slang
1 participant
@OmarTawfik