fix: Use a static rather than const for DSL V1 Grammar node instance #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously used const for the `fn instance()` meaning it always returned a fresh copy with a separate allocation. The fixed behaviour should better match the intent of handing out `Rc`s to a single instance. Found with Clippy.
|
OmarTawfik
approved these changes
Nov 2, 2023
|
This fixes two instances of Clippy lints, so I also removed them from the RUSTFLAGS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously used const for the
fn instance()meaning it always returned a fresh copy with a separate allocation. The fixed behaviour should better match the intent of handing outRcs to a single instance.Found with Clippy.