fix: Use a static rather than const for DSL V1 Grammar node instance (#…

…627)

This previously used const for the `fn instance()` meaning it always
returned a fresh copy with a separate allocation. The fixed behaviour
should better match the intent of handing out `Rc`s to a single
instance.

Found with Clippy.

.cargo/config.toml

@@ -14,16 +14,12 @@ rustflags = [
 	"-A",
 	"clippy::bool_assert_comparison",
 	"-A",
-	"clippy::borrow_interior_mutable_const",
-	"-A",
 	"clippy::cmp_owned",
 	"-A",
 	"clippy::collapsible_if",
 	"-A",
 	"clippy::comparison_chain",
 	"-A",
-	"clippy::declare_interior_mutable_const",
-	"-A",
 	"clippy::enum_variant_names",
 	"-A",
 	"clippy::expect_fun_call",

crates/codegen/grammar/src/dsl.rs

@@ -182,11 +182,14 @@ macro_rules! slang_grammar_definition {
         impl $name {
             const SOURCE_LOCATION: $crate::SourceLocation = slang_location!();
             const NAME: &str = stringify!($name);
-            const INSTANCE: ::std::cell::OnceCell<std::rc::Rc<Self>> = ::std::cell::OnceCell::new();
             fn instance() -> $crate::$trait_ref {
-                Self::INSTANCE
-                    .get_or_init(::std::default::Default::default)
-                    .clone()
+                use ::std::rc::Rc;
+
+                thread_local! {
+                    static INSTANCE: Rc<$name> = Rc::default();
+                }
+
+                INSTANCE.with(Rc::clone)
             }
         }