Remove all binding results ranking and use all found definitions instead #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in some references being resolved to many ambiguous definitions, some of which we were able to resolve via ranking.
…assertions to snapshots
Most remaining assertion tests were redundant as there were already snapshots that cover those cases.
This also removes the ranking algorithm for resolution results, since it's no longer needed.
|
OmarTawfik
reviewed
Dec 18, 2024
OmarTawfik
reviewed
Dec 18, 2024
OmarTawfik
reviewed
Dec 18, 2024
...s/solidity/testing/snapshots/bindings_output/built_ins/shadowing/generated/0.7.1-success.txt
Outdated
Show resolved
Hide resolved
OmarTawfik
requested changes
Dec 18, 2024
This fixes some ambiguities especially with built-ins.
OmarTawfik
approved these changes
Dec 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Rebasing #1198 on latest after #1195 was merged. --------- Co-authored-by: Gustavo Giráldez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
resolve_definition()and consequently all the ranking machinery associated with it, including C3 linearisation and bindings context, which was used for virtual method lookups. Also deprecates binding assertions in favour of straight snapshots. This simplifies the binding resolution code quite a bit.