Use database of partial paths to speed up bindings resolution #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in some references being resolved to many ambiguous definitions, some of which we were able to resolve via ranking.
…assertions to snapshots
Most remaining assertion tests were redundant as there were already snapshots that cover those cases.
This also removes the ranking algorithm for resolution results, since it's no longer needed.
…attributes This *should* make it easier to construct a partial paths databases in which these nodes are endpoints.
|
ggiraldez
force-pushed
the
hooks-database-stitching
branch
2 times, most recently
from
5d3a2e6 to
156722b
Compare
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
OmarTawfik
reviewed
Dec 20, 2024
crates/codegen/runtime/cargo/wasm/src/runtime/wrappers/bindings/mod.rs
Outdated
Show resolved
Hide resolved
This uses the added `save_checkpoint`/`restore_checkpoint` which rewind the allocation pointer in the `PartialPaths` arenas. For this to work properly, we also first `ensure_both_directions` in the database so that after that it doesn't need further mutation.
The database resolver will resolve all references at once by using a database of minimal partial paths.
… the `BindingGraph`
This makes it impossible to try to access definitions/references before resolving, and allows dropping the entire stack graph and database of partial paths used for resolution after they are no longer necessary.
ggiraldez
force-pushed
the
hooks-database-stitching
branch
from
15f35da to
8c55602
Compare
|
After #1195 is merged, I'll rebase this PR and the conflicts should be resolved. |
…records The `definitions` test name is now a bit misleading since no definitions are retrieved there, but it's still where user source files are ingested.
|
Replaced by #1204 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Rebasing #1198 on latest after #1195 was merged. --------- Co-authored-by: Gustavo Giráldez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1195
DefinitionandReferenceto hold aRc<>to theBindingGraphas opposed to a normal reference. This should allow easier integration with WASM since there are already wrappers for ref counted objects.BindingGraphand splint off aBindingGraphBuilderin which to add user files and built-ins and then callresolve()which will consume the builder and return a leanerBindingGraphwith all bindings resolved.stack-graphswhich adds the ability to rewind the arena allocator used for partial paths after resolving each reference, but still allows using the default database to hold the set of minimal partial paths.