Hmac separate #75
rust.yml
on: pull_request
build
36s
clippy_check
32s
Annotations
1 error and 10 warnings
build
Process completed with exit code 2.
|
variant name ends with the enum's name:
src/lib/types.rs#L77
warning: variant name ends with the enum's name
--> src/lib/types.rs:77:5
|
77 | InternalError = 0xFA,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
use of a fallible conversion when an infallible one could be used:
src/lib/transport.rs#L380
warning: use of a fallible conversion when an infallible one could be used
--> src/lib/transport.rs:380:46
|
380 | let webcrypt: WebcryptRequest = keyh.try_into().map_err(|_| Error::BadFormat)?;
| ^^^^^^^^ help: use: `into`
|
= note: converting `&[u8]` to `WebcryptRequest` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/lib/ctap_app.rs#L216
warning: use of a fallible conversion when an infallible one could be used
--> src/lib/ctap_app.rs:216:50
|
216 | display_name: Some("display".try_into().unwrap()),
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= note: converting `&str` to `String<64>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/lib/ctap_app.rs#L215
warning: use of a fallible conversion when an infallible one could be used
--> src/lib/ctap_app.rs:215:39
|
215 | name: Some("name".try_into().unwrap()),
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= note: converting `&str` to `String<64>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/lib/commands.rs#L1160
warning: use of a fallible conversion when an infallible one could be used
--> src/lib/commands.rs:1160:26
|
1160 | .map(|entry| PathBuf::try_from(entry.path()).unwrap());
| ^^^^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `&Path` to `PathBuf` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/lib/commands.rs#L1151
warning: use of a fallible conversion when an infallible one could be used
--> src/lib/commands.rs:1151:22
|
1151 | .map(|entry| PathBuf::try_from(entry.path()).unwrap());
| ^^^^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `&Path` to `PathBuf` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
unused import: `ctap_types::ctap1::Error as U2fError`:
src/lib/commands.rs#L2
warning: unused import: `ctap_types::ctap1::Error as U2fError`
--> src/lib/commands.rs:2:9
|
2 | pub use ctap_types::ctap1::Error as U2fError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|