Hmac separate #16
Merged
Hmac separate #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
hmac-separate
branch
3 times, most recently
from
d92f4b0
to
f85aa88
Compare
|
As the extension is only intended to be used with this crate as a workaround, we could also put it directly into this repository. That would probably be easier to maintain. |
|
Right, that's probably a better idea indeed. |
sosthene-nitrokey
force-pushed
the
hmac-separate
branch
3 times, most recently
from
f1b25ef
to
183524b
Compare
|
I moved the backend here. |
sosthene-nitrokey
force-pushed
the
hmac-separate
branch
from
183524b
to
c382711
Compare
sosthene-nitrokey
force-pushed
the
hmac-separate
branch
from
c382711
to
5f8075f
Compare
|
Should we tag with this PR or with main also? |
robin-nitrokey
approved these changes
Mar 4, 2024
daringer
approved these changes
Mar 4, 2024
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #15
This PR stops depending on trussed-staging for the never-merged HMACSHA256P256 extension and uses a custom backend instead (https://github.com/Nitrokey/trussed-hmacsha256p256)