Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igwejk/even up the defaults across ghas features #142

Merged
merged 8 commits into from
Mar 11, 2024
Merged

igwejk/even up the defaults across ghas features #142

merged 8 commits into from
Mar 11, 2024

Commits on Feb 29, 2024

  1. Remove .vscode/launch.json in favour of npm scripts

    @igwejk
    igwejk committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    06e4922 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Implement validation of feature enablement config

    @igwejk
    igwejk committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e85852e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Separately implement filter and mapping predicates 

    The predicates are for filtering or mapping repository nodes.
    @igwejk
    igwejk committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    55deda2 View commit details
    Browse the repository at this point in the history

  2. Ensure paginateQuery fulfills only its concern 

    paginateQuery should focus on the concern of returning repositories, and should not modify query results.
    @igwejk
    igwejk committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2448a8d View commit details
    Browse the repository at this point in the history

  3. Consider repository characteristics for feature 

    Individual repository characteristics should determin how features are enabled.
    @igwejk
    igwejk committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e6f37f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Control calls to predicates 

    Otherwise they are passed wrong parameter values that stops good defaults from being used.
    @igwejk
    igwejk committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    0164169 View commit details
    Browse the repository at this point in the history

  2. Skip attempting to enable GHAS for public repos 

    Because it can't be disabled anyway.
    @igwejk
    igwejk committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    f310d51 View commit details
    Browse the repository at this point in the history

  3. Add package-lock.json

    @igwejk
    igwejk committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7f45495 View commit details
    Browse the repository at this point in the history