Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable nfs_clients.yaml template by default in Rest Collector #2219

Merged
merged 4 commits into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions conf/rest/9.7.0/nfs_clients.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This template is disabled by default because it may slow down data collection

name: NFSClients
query: api/protocols/nfs/connected-clients
object: nfs_clients
Expand Down
2 changes: 1 addition & 1 deletion conf/rest/default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ objects:
NetConnections: netconnections.yaml
# NetPort: netport.yaml
NetRoute: netroute.yaml
NFSClients: nfs_clients.yaml
# NFSClients: nfs_clients.yaml
Node: node.yaml
NtpServer: ntpserver.yaml
OntapS3: ontap_s3.yaml
Expand Down
2 changes: 1 addition & 1 deletion grafana/dashboards/cmode/nfs_clients.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
},
"id": 29,
"options": {
"content": "You must enable the Rest collector in your harvest.yml config and uncomment the nfs_clients.yaml section in your $HARVEST/conf/rest/default.yaml file. Please see https://github.com/NetApp/harvest/wiki/FAQ#nfs-clients-dashboard for more details",
"content": "You must enable the Rest collector in your `harvest.yml` config and uncomment the `nfs_clients.yaml` section in your `$HARVEST/conf/rest/default.yaml` file. Please see [nfs clients dashboard](https://github.com/NetApp/harvest/wiki/FAQ#nfs-clients-dashboard) for more details. Enabling `nfs_clients.yaml` may slow down data collection.",
"mode": "markdown"
},
"pluginVersion": "8.1.8",
Expand Down
1 change: 1 addition & 0 deletions integration/test/dashboard_json_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ var excludeCounters = []string{
"svm_read_total",
"svm_vscan",
"svm_write_total",
"nfs_clients_",
}

var flakyCounters = []string{
Expand Down