Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable nfs_clients.yaml template by default in Rest Collector #2219

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

cgrinds
cgrinds previously approved these changes Jul 19, 2023
@rahulguptajss rahulguptajss linked an issue Jul 19, 2023 that may be closed by this pull request
@Hardikl
Copy link
Contributor

Hardikl commented Jul 19, 2023

shouldn't we comment this line https://github.com/NetApp/harvest/blob/main/conf/rest/default.yaml#L24 ?

@cgrinds
Copy link
Collaborator

cgrinds commented Jul 19, 2023

shouldn't we comment this line https://github.com/NetApp/harvest/blob/main/conf/rest/default.yaml#L24 ?

Yes! Good catch

@rahulguptajss
Copy link
Contributor Author

shouldn't we comment this line https://github.com/NetApp/harvest/blob/main/conf/rest/default.yaml#L24 ?

Added

conf/rest/9.7.0/nfs_clients.yaml Outdated Show resolved Hide resolved
grafana/dashboards/cmode/nfs_clients.json Outdated Show resolved Hide resolved
@rahulguptajss rahulguptajss merged commit 4b66863 into main Jul 19, 2023
@rahulguptajss rahulguptajss deleted the rg2-connected-clients branch July 19, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable nfs_clients collection in Rest Collector by default
3 participants