-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workload panels in workload dashboard #2100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
force-pushed
the
rg2-workload-dash
branch
from
May 19, 2023 13:24
29c1341
to
9c12d51
Compare
Hardikl
previously approved these changes
May 22, 2023
rahulguptajss
force-pushed
the
rg2-workload-dash
branch
from
May 23, 2023 06:18
65b5981
to
4d5b123
Compare
Updated PR as per https://github.com/NetApp/harvest-private/discussions/142 |
Hardikl
reviewed
May 29, 2023
Hardikl
previously approved these changes
May 30, 2023
Ready for review |
rahulguptajss
force-pushed
the
rg2-workload-dash
branch
from
June 16, 2023 08:18
4f498c3
to
5e4c10c
Compare
cgrinds
previously approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, these changes look good and remove special cases.
Please add as a comment, in this pull request, the high-level description we wordsmithed in email.
docs: incorporate PaulS panel descriptions. Thanks Paul!
cgrinds
reviewed
Aug 8, 2023
Hardikl
previously approved these changes
Aug 9, 2023
cgrinds
approved these changes
Aug 11, 2023
Hardikl
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the workload templates, specifically the
workload.yaml
andworkload_volume.yaml
templates, as well asworkload_detail.yaml
andworkload_detail_volume.yaml
. For the purpose of this discussion, we will focus on theworkload.yaml
andworkload_volume.yaml
templates, although the same applies toworkload_detail.yaml
andworkload_detail_volume.yaml
.Currently, there are three different workload classes:
user_defined
,system_defined
, andautovolume
. However, we discovered an issue in the templates where theuser_defined
workloads were being collected twice, once inworkload.yaml
and again inworkload_volume.yaml
. To address this problem, we have implemented the following solutions:Modification of workload_volume.yaml: This template will now only collect
autovolume
workloads, removing the collection ofuser_defined
workloads. Theworkload.yaml
template will be responsible for collecting bothuser_defined
andsystem_defined
workloads. If you prefer the previous behavior and want to collectuser_defined
workloads inworkload_volume.yaml
, you can adjust theworkload_class
parameter in the workload templates according to your needs.Update of the 'object' field in workload_volume.yaml: We have aligned the 'object' field in
workload_volume.yaml
with the workload.yaml template, changing it to 'qos'. This change simplifies the process of querying workloads. However, it is important to note that this modification may break backward compatibility. If you are affected by this change, you can easily make the necessary adjustment by changing the 'object' field in yourworkload_volume.yaml
template.