Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workload panels in workload dashboard #2100

Merged
merged 35 commits into from
Aug 11, 2023
Merged

Conversation

rahulguptajss
Copy link
Contributor

@rahulguptajss rahulguptajss commented May 19, 2023

This PR changes the workload templates, specifically the workload.yaml and workload_volume.yaml templates, as well as workload_detail.yaml and workload_detail_volume.yaml. For the purpose of this discussion, we will focus on the workload.yaml and workload_volume.yaml templates, although the same applies to workload_detail.yaml and workload_detail_volume.yaml.

Currently, there are three different workload classes: user_defined, system_defined, and autovolume. However, we discovered an issue in the templates where the user_defined workloads were being collected twice, once in workload.yaml and again in workload_volume.yaml. To address this problem, we have implemented the following solutions:

Modification of workload_volume.yaml: This template will now only collect autovolume workloads, removing the collection of user_defined workloads. The workload.yaml template will be responsible for collecting both user_defined and system_defined workloads. If you prefer the previous behavior and want to collect user_defined workloads in workload_volume.yaml, you can adjust the workload_class parameter in the workload templates according to your needs.

Update of the 'object' field in workload_volume.yaml: We have aligned the 'object' field in workload_volume.yaml with the workload.yaml template, changing it to 'qos'. This change simplifies the process of querying workloads. However, it is important to note that this modification may break backward compatibility. If you are affected by this change, you can easily make the necessary adjustment by changing the 'object' field in your workload_volume.yaml template.

Hardikl
Hardikl previously approved these changes May 22, 2023
@rahulguptajss rahulguptajss marked this pull request as ready for review May 25, 2023 15:57
@rahulguptajss
Copy link
Contributor Author

Updated PR as per https://github.com/NetApp/harvest-private/discussions/142

Hardikl
Hardikl previously approved these changes May 30, 2023
@rahulguptajss
Copy link
Contributor Author

Ready for review

cgrinds
cgrinds previously approved these changes Jun 22, 2023
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these changes look good and remove special cases.

Please add as a comment, in this pull request, the high-level description we wordsmithed in email.

integration/test/dashboard_json_test.go Show resolved Hide resolved
docs: incorporate PaulS panel descriptions. Thanks Paul!
conf/zapiperf/cdot/9.8.0/workload.yaml Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf.go Outdated Show resolved Hide resolved
cmd/collectors/zapiperf/zapiperf.go Show resolved Hide resolved
cmd/collectors/restperf/restperf.go Outdated Show resolved Hide resolved
cmd/collectors/restperf/restperf.go Outdated Show resolved Hide resolved
cmd/collectors/restperf/restperf.go Outdated Show resolved Hide resolved
Hardikl
Hardikl previously approved these changes Aug 9, 2023
cmd/collectors/restperf/restperf.go Outdated Show resolved Hide resolved
grafana/dashboards/cmode/workload.json Outdated Show resolved Hide resolved
@rahulguptajss rahulguptajss merged commit 9ff6868 into main Aug 11, 2023
9 checks passed
@rahulguptajss rahulguptajss deleted the rg2-workload-dash branch August 11, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ONTAP: Workload graph needs qos-detail and -node filter
3 participants