-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter St. John <[email protected]>
pstjohn
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
January 10, 2025 18:24
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 87.73% 88.78% +1.04%
==========================================
Files 89 81 -8
Lines 5758 5027 -731
==========================================
- Hits 5052 4463 -589
+ Misses 706 564 -142 ☔ View full report in Codecov by Sentry. |
jstjohn
approved these changes
Jan 10, 2025
jstjohn
reviewed
Jan 10, 2025
sub-packages/bionemo-esm2/tests/bionemo/esm2/scripts/test_pydantic_train.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter St. John <[email protected]>
pstjohn
changed the title
Temporarily disable pydantic tests
Add support for marking slow tests, temporarily mark pydantic tests as slow
Jan 10, 2025
pstjohn
changed the title
Add support for marking slow tests, temporarily mark pydantic tests as slow
Add support for marking and skipping slow tests, temporarily mark pydantic tests as slow
Jan 10, 2025
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
/build-ci |
dorotat-nv
approved these changes
Jan 13, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These pydantic CLI tests are currently taking an inordinate amount of time to run. This PR adds support for using
pytest.mark.slow
to flag tests not to run during pre-merge testing, but will still be run during nightly tests.Also adds some cleanup to the azure runner test suite to remove the docker container from the GPU runner since these are not ephemeral workers, and updates the cache mounting location for the container job to re-use downloads.
See https://nvidia.slack.com/archives/C074Z808N05/p1736460988702949
https://jirasw.nvidia.com/browse/BIONEMO-553
Type of changes
CI Pipeline Configuration
Configure CI behavior by checking relevant boxes below. This will automatically apply labels.
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
Pre-submit Checklist