Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake config to support building shared libraries #1559

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

srherbener
Copy link
Contributor

@srherbener srherbener commented Jul 24, 2024

Description

This PR adds CMake configuration to optionally build shared libraries. Building static libraries remains the default action.

Fixes #1558

How Has This Been Tested?

I tested these changes on my Mac laptop. I verified that static libraries build by default and by using the cmake command line option -DSHARED_LIBS that shared libraries were build instead.

JEDI is currently using FMS 2023.04 and I tested these changes (relative to the 2023.04 version of CMakeLists.txt) and verified that FV3-GFS built successfully with either static or shared FMS libraries, and indeed the issue with the static libraries is fixed by using shared libraries instead.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@climbfuji
Copy link
Contributor

I support these changes, thanks @srherbener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for shared library creation
4 participants