Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need shared (dynamic) libraries for FMS on MacOS #1211

Closed
srherbener opened this issue Jul 26, 2024 · 1 comment · Fixed by JCSDA/spack#471
Closed

Need shared (dynamic) libraries for FMS on MacOS #1211

srherbener opened this issue Jul 26, 2024 · 1 comment · Fixed by JCSDA/spack#471
Assignees
Labels
INFRA JEDI Infrastructure

Comments

@srherbener
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When we moved to [email protected], many ctests started to fail on MacOS. We discovered that the issue was using static FMS libraries along with the Mac two-level namespace linker/loader scheme. Using shared FMS libraries (built manually) fixed this issue. For details, see: https://github.com/JCSDA-internal/fv3-jedi/issues/1237.

I submitted a PR to the NOAA-GFDL FMS repo to add in the option to build shared libraries: NOAA-GFDL/FMS#1559

I've put a workaround in place for JCSDA to get us by for now: https://github.com/JCSDA/FMS/blob/feature/mac-fms-2023.04/JEDI_BUNDLE_BUILD_ON_MACOS.md

We need to apply an equivalent patch/workaround to the build process for [email protected] when building on MacOS to hold us over until we move to whatever version of FMS will have the shared library option in the above PR.

Describe the solution you'd like

I was thinking of creating a "shared" variant that would apply a patch to have FMS build shared libraries, which would be off by default and turned on for the macos build.

Additional context
Add any other context or screenshots about the feature request here.

@srherbener srherbener self-assigned this Jul 26, 2024
@srherbener srherbener added the INFRA JEDI Infrastructure label Jul 26, 2024
@srherbener srherbener changed the title Need share (dynamic) libraries for FMS on MacOS Need shared (dynamic) libraries for FMS on MacOS Jul 26, 2024
@eap
Copy link
Collaborator

eap commented Aug 19, 2024

We may push this feature out to 1.9: this is currently covered by a workaround. It would be nice to have this but there's enough needed for the 1.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
Development

Successfully merging a pull request may close this issue.

2 participants