-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config for MacOS Sonoma 14.6.1 with Command Line Tools 15.3 #1281
Config for MacOS Sonoma 14.6.1 with Command Line Tools 15.3 #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, waiting for the spack submodule PR to be merged.
…into feature/enable-mac-sonoma
…into feature/enable-mac-sonoma
03711ee
to
bba7529
Compare
@eap This PR with its spack submodule update is ready for your testing. CI is still running, but I will double check once it is done that fms is indeed built as shared library for macOS, and as static library for Linux. |
macOS CI run uses fms+shared: https://github.com/JCSDA/spack-stack/actions/runs/10694317828/job/29645919837?pr=1281 |
…into feature/enable-mac-sonoma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found the issue with the fms build on my Mac - see the comment below.
…/packages.yaml and configs/common/packages.yaml so that the macOS settings get combined with the default settings
…ener/spack-stack into feature/enable-mac-sonoma
2c4cc42 hopefully fixes this! |
Thanks @climbfuji. I'll give that a try. |
2c4cc42 does indeed fix the issue. My Mac is now building fms with all the proper variants (both r4 and r8, GFS constants, etc.). Thanks! |
Summary
This PR adds in configuration to enable building on the latest versions of the MacOS and Command Line Tools (14.6.1 and 15.3 respectively).
The NewSiteConfig.rst documentation has been updated for building on the Mac.
Testing
I built spack-stack-1.8.0 with these changes on my Mac, then use that environment to successfully build jedi-bundle, and ran ctests which resulted in 35 test failures which is in alignment with jedi-bundle ctest-ing with spack-stack-1.7.0.
I'm also building the release candidates on Discover with these feature branches and have verified for both gcc and intel environments that FMS gets built with static libraries (as before). Testing of these release candidates will be underway as soon as the builds are complete.
Applications affected
Applications in the unified-dev environment: JEDI, MPAS, FV3, SOCA, etc.
Systems affected
Only the Mac should be impacted, the HPC platforms should build as before.
Dependencies
Waiting on JCSDA/spack/pull/471
Issue(s) addressed
Resolves #1249
Checklist