Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for Mac Sonoma 14.6.1 with Command Line Tools 15.3 #471

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

srherbener
Copy link
Collaborator

@srherbener srherbener commented Aug 30, 2024

This PR adds in the necessary configuration to get the latest MacOS and Command Line Tools versions working (14.6.1 and 15.3 respectively).

This PR includes a patch for FMS 2024.02 and a variant spec that builds shared (dylib) libraries. This makes it unnecessary to do the manual FMS build workaround that was recently published. The FMS patch is only needed for version 2024.02 in that the next version (2024.03) contains the update to the CMakeLists.txt file that adds in the shared library option.

Resolves JCSDA/spack-stack/issues/1211

@srherbener srherbener changed the base branch from spack-stack-dev to release/1.8.0 August 30, 2024 20:20
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates. Any plans to send those upstream to spack develop?

var/spack/repos/builtin/packages/fms/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/fms/package.py Outdated Show resolved Hide resolved
@climbfuji
Copy link
Collaborator

Might be better to apply the patch in the same way as the spack developers suggested it for the bufr-query library.

@climbfuji
Copy link
Collaborator

spack develop PR for py-netcdf4 and py-ruamel-yaml-clib is here: spack#46184

Unfortunately, I couldn't cherry-pick the changes from this PR since everything was submitted in one commit. We should split this into one commit per package (as I did in spack#46184). We can cherry-pick those commits later and fix the conflicts in our branch.

@climbfuji
Copy link
Collaborator

Might be better to apply the patch in the same way as the spack developers suggested it for the bufr-query library.

Done as well.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create the upstream PR for fms tomorrow, but I am happy with the changes as they are now.

@climbfuji
Copy link
Collaborator

spack develop PR for py-netcdf4 and py-ruamel-yaml-clib is here: spack#46184

Unfortunately, I couldn't cherry-pick the changes from this PR since everything was submitted in one commit. We should split this into one commit per package (as I did in spack#46184). We can cherry-pick those commits later and fix the conflicts in our branch.

Pull request for fms in spack develop: spack#46238

@climbfuji
Copy link
Collaborator

spack develop PR for py-netcdf4 and py-ruamel-yaml-clib was merged into spack develop (spack#46184)

@srherbener
Copy link
Collaborator Author

Spack stack built successfully on my Mac, but when running ecbuild on jedi-bundle, the FMS::fms_r8 component was not found. Upon inspection, only the FMS::fms_r4 component was built. I think before both the r4 and r8 components were built. Is this an intended change?

@climbfuji
Copy link
Collaborator

Spack stack built successfully on my Mac, but when running ecbuild on jedi-bundle, the FMS::fms_r8 component was not found. Upon inspection, only the FMS::fms_r4 component was built. I think before both the r4 and r8 components were built. Is this an intended change?

None of my changes should have an effect on which version(s) get(s) built

@srherbener
Copy link
Collaborator Author

Spack stack built successfully on my Mac, but when running ecbuild on jedi-bundle, the FMS::fms_r8 component was not found. Upon inspection, only the FMS::fms_r4 component was built. I think before both the r4 and r8 components were built. Is this an intended change?

I think the changes here are okay. I think I found the issue in the spack-stack configuration. See this comment: JCSDA/spack-stack#1281 (comment)

@climbfuji climbfuji merged commit 1b3e3e5 into JCSDA:release/1.8.0 Sep 10, 2024
15 checks passed
@srherbener srherbener deleted the feature/enable-mac-sonoma branch September 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants