Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10 schemaedit #12

Merged
merged 6 commits into from
Jul 26, 2024
Merged

10 schemaedit #12

merged 6 commits into from
Jul 26, 2024

Conversation

aradhakrishnanGFDL
Copy link
Collaborator

#10

@aradhakrishnanGFDL aradhakrishnanGFDL self-assigned this Jul 23, 2024
@aradhakrishnanGFDL aradhakrishnanGFDL linked an issue Jul 23, 2024 that may be closed by this pull request
schema edits for MDTF interoperability #10
Closed
ceblanton
ceblanton approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There's a bit of duplication which is okay. The main template (cats/gfdl_template.json) is already updated, I think.

Ciheim
Ciheim approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@Ciheim Ciheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@aradhakrishnanGFDL aradhakrishnanGFDL merged commit 2d6222d into main Jul 26, 2024
3 checks passed
@aradhakrishnanGFDL aradhakrishnanGFDL deleted the 10-schemaedit branch July 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ciheim Ciheim Ciheim approved these changes

@ceblanton ceblanton ceblanton approved these changes

Assignees

@aradhakrishnanGFDL aradhakrishnanGFDL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema edits for MDTF interoperability
3 participants
@aradhakrishnanGFDL @ceblanton @Ciheim