Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema edits for MDTF interoperability #10

Closed
aradhakrishnanGFDL opened this issue Jul 23, 2024 · 3 comments · Fixed by #12
Closed

schema edits for MDTF interoperability #10

aradhakrishnanGFDL opened this issue Jul 23, 2024 · 3 comments · Fixed by #12
Assignees

Comments

@aradhakrishnanGFDL
Copy link
Collaborator

aradhakrishnanGFDL commented Jul 23, 2024

Following this NOAA-GFDL/MDTF-diagnostics#588, this issue tracks the following changes to the schema

Change: modeling_realm to realm (GFDL Catalog Builder)
Change: temporal_subset to time_range (GFDL Catalog Builder)
Add: standard_name (GFDL Catalog Builder)

@aradhakrishnanGFDL aradhakrishnanGFDL self-assigned this Jul 23, 2024
@aradhakrishnanGFDL aradhakrishnanGFDL linked a pull request Jul 23, 2024 that will close this issue
@ceblanton
Copy link
Contributor

@aradhakrishnanGFDL
Copy link
Collaborator Author

This is already fixed, isn't it?

https://github.com/NOAA-GFDL/CatalogBuilder/blob/main/catalogbuilder/cats/gfdl_template.json

Yes, but just the json seemed to updated. We need sample config yaml files and the test configs in CI also to be updated which is now done.

@aradhakrishnanGFDL
Copy link
Collaborator Author

standard_name addition is pending. @Ciheim this PR will add an empty column that you will fill in your feature addition, or want your PR to take care of that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants