Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for component land model #682

Merged
merged 45 commits into from
Jan 26, 2024
Merged

Conversation

uturuncoglu
Copy link
Contributor

Description

This PR aims to add support for fully coupled atmosphere-land component configuration.

  • Along with this PR, UFS Weather Model will have capability to run land component in higher resolution than the atmosphere.
  • The PR introduces new input.nml option as cpllnd2atm to keep supporting side-by-side configuration (both component NoahMP and CCPP/NoahMP runs and component NoahMP does not send information to FV3, it is important particularly to compare the results coming from component land with the one that runs under CCPP/Physics).
  • The implementation also tested with C96 FV3ATM and C384 component land configuration. -
  • There is no expected answer change for existing configurations.

Issue(s) addressed

N/A

Testing

How were these changes tested?

The full regression test suite is run on Orion and all tests passed except land component related ones since new land component rely on newer version of ESMF (8.5.0) to read/write multi-tile netcdf files.

What compilers / HPCs was it tested with? Intel / MSU's Orion

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Following new RTs are added,

  • control_p8_atmlnd: fully coupled ATM-LND configuration
  • control_restart_p8_atmlnd: tests restart capability of fully coupled ATM-LND configuration
  • datm_cdeps_lnd_era5: component land model forced with ERA5
  • datm_cdeps_lnd_era5_rst: tests restart capability of component land model forced with

Have the ufs-weather-model regression test been run? On what platform?
Once UFS Weather model switches to new version of ESMF (8.5.0) there might have some answer changes due to some changes in ESMF interpolation routines. The full release note can be seen in the following link: https://github.com/esmf-org/esmf/releases/tag/v8.5.0

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally) N/A

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

atmos_model.F90 Outdated Show resolved Hide resolved
@uturuncoglu
Copy link
Contributor Author

Testing now.

@uturuncoglu
Copy link
Contributor Author

@haiqinli If you don't mind could you also test in your side. I have just merged your ccpp/physics and FV3 forks to this branch.

@haiqinli
Copy link
Contributor

haiqinli commented Jan 24, 2024 via email

@grantfirl
Copy link
Collaborator

grantfirl commented Jan 26, 2024

ufs-community/ccpp-physics#94 is merged. This is ready to update the ccpp/physics submodule pointer and revert .gitmodules.
@uturuncoglu

@uturuncoglu
Copy link
Contributor Author

@grantfirl okay. done it.

@zach1221
Copy link
Collaborator

@grantfirl okay. done it.
@uturuncoglu can you ensure the ccpp-physics hash is updated as well?
ufs-community/ccpp-physics@d0c3294

@uturuncoglu
Copy link
Contributor Author

@zach1221 let me check

@uturuncoglu
Copy link
Contributor Author

@zach1221 sorry, I think it is done.

@zach1221
Copy link
Collaborator

@jkbk2004 this fv3atm sub-pr should be good to go. Can you please merge for us?

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 We need to ask ufuk to first merge the top of FV3, which contains documentation updates.

@jkbk2004
Copy link
Collaborator

@jkbk2004 We need to ask ufuk to first merge the top of FV3, which contains documentation updates.

@uturuncoglu there was a recent commit at fv3 develop. Can you sync up one more time?

@uturuncoglu
Copy link
Contributor Author

@jkbk2004 Okay, i synced. BTW, I still see changes in ccpp/physics.If you don't mind could you double check that all are fine.

@jkbk2004
Copy link
Collaborator

@jkbk2004 Okay, i synced. BTW, I still see changes in ccpp/physics.If you don't mind could you double check that all are fine.

I think changes just show diff against fv3/dev. Looks ok. I will let CI done and merge.

@uturuncoglu
Copy link
Contributor Author

@jkbk2004 Okay. That is great. BTW, thanks for all your help.

@jkbk2004 jkbk2004 merged commit 1d2c823 into NOAA-EMC:develop Jan 26, 2024
2 checks passed
@mkavulich
Copy link

@uturuncoglu Sorry to resurrect this discussion from the dead, but I had a question about your updates to the CCPP suite suite_FV3_GFS_v17_p8.xml: should the sfc_land scheme be added to other GFS v17 prototype suites as well? It seems like it only has an effect if cpllnd2atm=.true. in the namelist, so unless I'm missing something it couldn't hurt to add?

@uturuncoglu
Copy link
Contributor Author

@mkavulich I am not sure which suite file is used by GFS v17 but currently we have only in

<scheme>sfc_land</scheme>
. That is right. You could add it to any suite file and it will update the land fluxes only cpllnd2atm=.true. case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants