Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplementary physics updates for RRFS code freeze #773

Closed
wants to merge 4 commits into from

Conversation

haiqinli
Copy link
Contributor

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add?

MYNN: 1) cosmetic fix to the cloud fractions in (relatively rare) conditions with unsaturated grid cells and positive mixing ratios; 2) very slight increase in diffusion in stable conditions; 3) momentum transport bug fix--missing rho.
RUC LSM: Computation of the new snow fraction uses now snow with variable density to reduce cold bias.
GF: Adjust the scale-awareness in the 1st hour forecast to reduce precipitation bias.
Smoke and Dust: Fix the diurnal cycle of smoke, dust emission over frozen soil, dry deposition.

Is a change of answers expected from this PR?
Yes.

Testing

How were these changes tested? Regression test
What compilers / HPCs was it tested with? Intel/Hera

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. No new testes are needed.

Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    Yes, the results are changed by physics updates. /scratch2/BMC/acomp/Haiqin.Li/stmp4/Haiqin.Li/FV3_RT/rt_112955
  • Please commit the regression test log files in your ufs-weather-model branch. Committed.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? No

@DusanJovic-NOAA
Copy link
Collaborator

This PR depends on ccpp-physics, please list the corresponding ccpp PR in the Dependencies section of the description.

@grantfirl
Copy link
Collaborator

This PR depends on ccpp-physics, please list the corresponding ccpp PR in the Dependencies section of the description.

@DusanJovic-NOAA This PR was combined into #682.

@DusanJovic-NOAA
Copy link
Collaborator

Merged via #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants