APPT-587: Delete provisional bookings when their availability is removed

[sambiramairelogic]

Subsequent to the previous PR which prevented Provisional appointments from being orphaned when their availability is removed, we actually want to hard delete them in this scenario.

I have misgivings about hard deletes, but we're doing this during the nightly sweep so there is precedent, and after all it is only provisional.

[jsed-nhs]

Any reason we aren't soft deleting, just to free up data - no current predicted use for this data I assume? Only alternative could be soft delete and then hard delete after X amount of time, you mentioned some "nightly sweep" process?

[sambiramairelogic]

Any reason we aren't soft deleting, just to free up data - no current predicted use for this data I assume? Only alternative could be soft delete and then hard delete after X amount of time, you mentioned some "nightly sweep" process?

I asked the same question. If you want to do the extra dev work to make it a soft delete, be my guest and ask a BA for the time. The scope of this PR to delete the provisional bookings in the same way they are currently.

[jsed-nhs]

Approved when both async Delete calls run in parallel

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud