Parallelise delete calls

NHSDigital · Jan 29, 2025 · 8ff6c6b · 8ff6c6b
1 parent 644b6a9
commit 8ff6c6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/api/Nhs.Appointments.Persistance/BookingCosmosDocumentStore.cs b/src/api/Nhs.Appointments.Persistance/BookingCosmosDocumentStore.cs
@@ -192,9 +192,8 @@ public async Task<IEnumerable<string>> RemoveUnconfirmedProvisionalBookings()
         return indexDocuments.Select(i => i.Reference).ToList();
     }
 
-    public async Task DeleteBooking(string reference, string site)
-    {
-        await indexStore.DeleteDocument(reference, "booking_index");
-        await bookingStore.DeleteDocument(reference, site);
-    }
+    public async Task DeleteBooking(string reference, string site) => await Task.WhenAll(
+        indexStore.DeleteDocument(reference, "booking_index"),
+        bookingStore.DeleteDocument(reference, site)
+    );
 }    
diff --git a/tests/Nhs.Appointments.Core.UnitTests/BookingsServiceTests.cs b/tests/Nhs.Appointments.Core.UnitTests/BookingsServiceTests.cs
@@ -605,7 +605,7 @@ public async Task RecalculateAppointmentStatuses_DeletesProvisionalAppointments(
                         It.Is<AppointmentStatus>(s => s == AppointmentStatus.Orphaned)),
                     Times.Once);
 
-                _bookingsDocumentStore.Verify(x => x.DeleteProvisionalBooking(
+                _bookingsDocumentStore.Verify(x => x.DeleteBooking(
                         It.Is<string>(s => s == "2"),
                         It.Is<string>(s => s == "mock-site")),
                     Times.Once);