Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Themed Icons" for Android #220

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

rileychh
Copy link
Collaborator

@rileychh rileychh commented Feb 8, 2024

Description

This PR adds support for Themed Icons on Android. This feature allows users running Android 13 or later theme our app icon based on the system theme.

Implementation

  • Re-enable flutter_launcher_icons with the version added support for themed icons.
  • Add android.png with the background removed as the foreground for the adaptive icon.
  • Rename tat.png to original.png, and use this image for iOS and older Android versions.

Testing Instructions

Install the app on Android, drag a shortcut onto the home screen, and enable "Themed Icons" in the launcher settings. Verify that the TAT logo correctly follows the system theme.

Additional Notes

N/A.

ntut-xuan
ntut-xuan previously approved these changes Feb 12, 2024
Copy link
Collaborator

@ntut-xuan ntut-xuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ntut-xuan ntut-xuan added this to the 1.6 milestone Feb 12, 2024
@rileychh
Copy link
Collaborator Author

rileychh commented Feb 13, 2024

Just found out that the flutter_launcher_icons we use has added support for themed icons in a merged PR. Should we use this tool to generate these icons instead?

edit: to use this unreleased feature, we need to switch to the latest master version.

@rileychh rileychh changed the title feat: add "Themed Icons" for Android dd "Themed Icons" for Android Feb 14, 2024
@rileychh rileychh changed the title dd "Themed Icons" for Android Add "Themed Icons" for Android Feb 14, 2024
@rileychh
Copy link
Collaborator Author

Re-implemented with flutter_launcher_icons. Please review again.

@rileychh
Copy link
Collaborator Author

Please note that this PR is blocked by #224. Without a proper splash screen for Android 12 and later, the app will launch with 2 splash screens.

Demonstration:
screen-20240219-164753

Details about double splash screen: https://stackoverflow.com/questions/77098464/play-console-pre-launch-warning-double-splash-screen

Copy link
Collaborator

@ntut-xuan ntut-xuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's blocked by #224, I suggest to change the PR into draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants