-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: WRF CMake Changes #739
Merged
scrasmussen
merged 7 commits into
NCAR:main
from
scrasmussen:enhancement/WRF-CMake-changes
Sep 26, 2024
Merged
Enhancement: WRF CMake Changes #739
scrasmussen
merged 7 commits into
NCAR:main
from
scrasmussen:enhancement/WRF-CMake-changes
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just making a note so it doesn't get overlooked: just need to make sure the last few commits/changes in the WRF PR#2009 are pulled in to this one so they match. After that it should be good to open this PR again. |
scrasmussen
force-pushed
the
enhancement/WRF-CMake-changes
branch
from
May 23, 2024 03:48
dc2d2bb
to
f93115a
Compare
Brought over the last few changes from the WRF PR#2009, this PR is ready for review. |
rcabell
previously approved these changes
May 23, 2024
scrasmussen
force-pushed
the
enhancement/WRF-CMake-changes
branch
from
June 5, 2024 15:57
468486a
to
0a5c290
Compare
scrasmussen
force-pushed
the
enhancement/WRF-CMake-changes
branch
from
July 20, 2024 17:15
0a5c290
to
3862d30
Compare
scrasmussen
force-pushed
the
enhancement/WRF-CMake-changes
branch
from
September 26, 2024 17:38
3862d30
to
7b7b743
Compare
…ces and enforcing uniform style guide
scrasmussen
force-pushed
the
enhancement/WRF-CMake-changes
branch
from
September 26, 2024 17:46
7b7b743
to
51aac4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: CMake, WRF, Build System
SOURCE: Soren Rasmussen and Ryan Cabell, NCAR
DESCRIPTION OF CHANGES: Branched from PR #733. Changes copied over from the new WRF hydro CMake PR.. A few additions were removed since WRF-Hydro's CMake handles NetCDF libraries differently. Style guide changes are brought over and there is cleanup in the CMakeLists.txt files. This include tabs to spaces, indentation is more consistent across files. Multiple
add_depencency
function calls are combined into one if able.NOTES:
Checklist
NEWS.md