Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: WRF CMake Changes #739

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

scrasmussen
Copy link
Member

TYPE: enhancement

KEYWORDS: CMake, WRF, Build System

SOURCE: Soren Rasmussen and Ryan Cabell, NCAR

DESCRIPTION OF CHANGES: Branched from PR #733. Changes copied over from the new WRF hydro CMake PR.. A few additions were removed since WRF-Hydro's CMake handles NetCDF libraries differently. Style guide changes are brought over and there is cleanup in the CMakeLists.txt files. This include tabs to spaces, indentation is more consistent across files. Multiple add_depencency function calls are combined into one if able.

NOTES:

  • Branched from PR Enhancement: .F to .F90 #733. That one should be merged first.
  • Linking MPI changes were brought over because even though it built correctly on Derecho without them, for WRF they were needed for local builds on OSX. It's possible this failure is only in WRF but not sure.
target_link_libraries(hydro_netcdf_layer
        MPI::MPI_Fortran
)

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

@scrasmussen scrasmussen marked this pull request as draft March 22, 2024 16:42
@scrasmussen
Copy link
Member Author

Just making a note so it doesn't get overlooked: just need to make sure the last few commits/changes in the WRF PR#2009 are pulled in to this one so they match. After that it should be good to open this PR again.

@scrasmussen scrasmussen force-pushed the enhancement/WRF-CMake-changes branch from dc2d2bb to f93115a Compare May 23, 2024 03:48
@scrasmussen scrasmussen marked this pull request as ready for review May 23, 2024 04:07
@scrasmussen
Copy link
Member Author

Brought over the last few changes from the WRF PR#2009, this PR is ready for review.

rcabell
rcabell previously approved these changes May 23, 2024
@scrasmussen scrasmussen merged commit 7cbd1e4 into NCAR:main Sep 26, 2024
4 checks passed
@rcabell rcabell added this to the WRF-Hydro v5.4 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants