Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: .F to .F90 #733

Closed
wants to merge 5 commits into from

Conversation

scrasmussen
Copy link
Member

TYPE: enhancement

KEYWORDS: build system, filename extension

SOURCE: Soren Rasmussen

DESCRIPTION OF CHANGES:

  • .F to .F90 filename change. WRF is moving to CMake with PR#1896 and these changes will make creating the flags for the CMake build easier. Non-standard but communitee standard behavior is to preprocess a file if the extension is capitalized and to treat non .F70 file extensions are free form.
  • Small dependency fix to the CMake nudging configuration so the parallel build doesn't break.

TESTS CONDUCTED: Build a few different configuration and ran standard Conus.

NOTE: NoahMP files left unchanged since this will be a submodule soon, hopefully!

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

@scrasmussen
Copy link
Member Author

PR #739 has these changes so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant