Collection iteration optimization #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works out to ~1000 dump files if iteration takes one week, which seems sane
also fixes a bug in the test where expected content was compared with itself rather than the actual output
does not update deprecated scroll-based implementation
…written for bundles
This reverts commit a001d52.
…tion does not exist in registry
…pages during ancestry
…e collection does not exist in registry
reverts 9548917 alternate_ids are not considered reliable for this purpose, and the relevant feature requires reimplementation
previously, nil records/updates would not cause failure of some test cases
bulk updates are often taking longer than 90 seconds
aliases are not working, and have been removed
…s not reliable and should not be used
…in list of its own references
alexdunnjpl
requested review from
tloubrieu-jpl,
nutjob4life and
collinss-jpl
as code owners
nutjob4life
reviewed
Apr 12, 2024
nutjob4life
approved these changes
Apr 12, 2024
Deferred partial updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Overhauls ancestry sweeper - non-essential global state is eliminated in favor of iterating over collections when generating updates.
This results in vastly less peak memory usage while avoiding the need to use HDD for swap, and facilitates incremental processing even if job is killed or otherwise fails.
Squash when merging.
N.B. tqdm is introduced, but I've experienced some instability when running in debug mode in Pycharm. Investigation suggests this is platform-specific, so I'm keeping it in there, and a future update should resolve this, but it's something to be aware of and disabling the tqdm progress bar may be necessary during development.
This bug may be worked around by disabling the cython speedup extension with env var
PYDEVD_USE_CYTHON=NO. This information has been added to the dev section in the readme⚙️ Test Data and/or Report
One of the following should be included here:
♻️ Related Issues
related to #108