Deferred partial updates #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, nil records/updates would not cause failure of some test cases
alexdunnjpl
requested review from
tloubrieu-jpl,
nutjob4life and
collinss-jpl
as code owners
alexdunnjpl
force-pushed
the
deferred-partial-updates
branch
from
804786f
to
482146a
Compare
nutjob4life
approved these changes
Apr 11, 2024
bulk updates are often taking longer than 90 seconds
aliases are not working, and have been removed
…s not reliable and should not be used
…in list of its own references
alexdunnjpl
merged commit 7c4c1ed
into
collection-iteration-optimization
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Implements handling of case where non-aggregate product histories - which are generated by stateless iteration over registry-refs collection documents as implemented in #115 - are shared among collections having a different LID than the one nominally indicated by the first five chunks of the non-agg's LID.
If multiple updates are detected for a single nonaggegate product, all records subsequent to the first are shelved to disk, and are later merged with each other and the first, which is retrieved from the database (as it has already been written - this is ensured by a write buffer flush prior before processing of deferred records). After merging, the full history of the deferred nonaggregate products is yielded and written to the database.
⚙️ Test Data and/or Report
Functional tests updated and pass.
Manual testing in progress.
♻️ Related Issues
Fixes #114