-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
263 fixed design split into smaller export function #271
Merged
LittleBeannie
merged 31 commits into
main
from
263-fixed_design-split-into-smaller-export-function
Jul 18, 2023
Merged
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ea6b144
`fixed_design` -> `fixed_design_ahr`
LittleBeannie c0bbcdf
`fixed_design` -> `fixed_design_fh`
LittleBeannie dc90411
`fixed_design` -> `fixed_design_lf`
LittleBeannie 5766e79
`fixed_design` -> `fixed_design_maxcombo`
LittleBeannie 13e343b
`fixed_design` -> `fixed_design_mb`
LittleBeannie 3f903b6
`fixed_design` -> `fixed_design_milestone`
LittleBeannie 53b6df1
`fixed_design` -> `fixed_design_rd`
LittleBeannie 694395d
`fixed_design` -> `fixed_design_rmst`
LittleBeannie 2b94a6f
delete `fixed_design`
LittleBeannie d6c61fa
update a warning in `as_gt`
LittleBeannie 232a2ec
update test file
LittleBeannie 43082e0
update vignette
LittleBeannie 785d453
update documentation
LittleBeannie 22e26bd
update pkgdown.ymn
LittleBeannie e6fc907
fix pkgdown and some lintr issues
LittleBeannie 279d036
fix lintr issue
LittleBeannie 14da125
fix cmd check
LittleBeannie 05d521a
fix pkgdown and lintr issues
LittleBeannie 661cf2e
fix cmd check and lintr issue
LittleBeannie b99d5d3
lintr
LittleBeannie e414af8
fix cmd check
LittleBeannie 9d0af24
update documentation
LittleBeannie 9f36b51
lintr issue
LittleBeannie 25d8667
fix warning from cmd check
LittleBeannie 1505dc6
update documentation
LittleBeannie d3ef23a
address yilong's comments
LittleBeannie 6a4b248
Merge branch 'main' into 263-fixed_design-split-into-smaller-export-f…
LittleBeannie a4905df
fix cmd check
LittleBeannie 1a76705
update documentation
LittleBeannie 12fd098
typo
LittleBeannie 4b87732
lintr
LittleBeannie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we use upper cases now? I thought we should use lower cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out! The
x
object is fromgs_design/power_xxx() |> summary()
, so all the column name is capitalized. Sentence case is used forsummary
output, andas_gt()
is just for formate transformation (R table -> gt table). In this way, even if users don't useas_gt
, they can use... |> summary() |> gt()
to get a sentence case table without any column renaming.