263 fixed design split into smaller export function #271
Conversation
| @@ -153,14 +151,14 @@ as_gt.fixed_design <- function(x, title = NULL, footnote = NULL, ...) { | |||
| "fh" = { | |||
| paste0( | |||
| "Power for Fleming-Harrington test ", | |||
| substr(x$design, 19, nchar(x$design)), | |||
| substr(x$Design, 19, nchar(x$Design)), | |||
There was a problem hiding this comment.
why would we use upper cases now? I thought we should use lower cases.
There was a problem hiding this comment.
Thanks for pointing it out! The x object is from gs_design/power_xxx() |> summary(), so all the column name is capitalized. Sentence case is used for summary output, and as_gt() is just for formate transformation (R table -> gt table). In this way, even if users don't use as_gt, they can use ... |> summary() |> gt() to get a sentence case table without any column renaming.
R/fixed_design_lf.R
Outdated
|
|
||
| #' Fixed design sample size | ||
| #' | ||
| #' Computes fixed design sample size for Lachin-Foulkes method. |
There was a problem hiding this comment.
As a user, I am confused what does LF method stands for.
A design needs to associate with a specific test. To me LF's paper is a general approach on piecewise enrollment and failure that can be applied to multiple tests.
If the function is related to log rank test with average hazard ration, do we really need this separate function? Or it is already covered by 'fixed_design_ahr'
There was a problem hiding this comment.
lf calls gsDesign functions. It is always hard to tell everything through a function name, so documentation (https://merck.github.io/gsDesign2/articles/usage-fixed-design.html) is important. If the documentation of fixed_design_xx is sufficient, then users can always go to the referenced paper for more details.
|
I updated the documentation of |
Thanks! I am fine to merge this PR given the good work you already have. Let's discuss function name in a meeting. Need some help to understand the details |
|
Sure, let's merge the PR first but keep the issue open for Friday's discussion. |
LittleBeannie
deleted the
263-fixed_design-split-into-smaller-export-function
branch
No description provided.