DataGridColumn: Add AggregateTemplate #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsrki
approved these changes
Mar 9, 2024
That would only work if the user defines all Aggregates for all columns displayed in the DataGrid. Because the aggregate need to be placed in an explicitly defined column to show properly. |
stsrki
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's redundant for most columns since
DisplayTemplatealready exists in theAggregateColumn.This best allows to configure each column individually including the Command and multi select columns and any additional special column we might introduce.
Maybe in the future we could consider in removing the
AggregateColumnDisplayTemplateinstead?What do you think?
Even the AggregateColumns definition could possibly be moved to the DataGridColumn, making the definition more centralized.
However I have to say I personally do like the separation.