Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGridAggregate Questions #5112

Closed
He-Wu opened this issue Oct 27, 2023 · 7 comments · Fixed by #5350
Closed

DataGridAggregate Questions #5112

He-Wu opened this issue Oct 27, 2023 · 7 comments · Fixed by #5350
Assignees
Labels
Area: DataGrid Type: Feature ⚙ Request or idea for a new feature.
Milestone

Comments

@He-Wu
Copy link

He-Wu commented Oct 27, 2023

Is your feature request related to a problem? Please describe.
I need to display total under the selection box, but setting it is useless. abc is not a field where TItem exists. I only need to display the string total.According to the following code, it will not display the total string at the bottom of the checkbox
image
image
image

Describe the solution you'd like
A clear and concise description of what you want to happen. Include any alternative solutions you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@He-Wu He-Wu added the Type: Feature ⚙ Request or idea for a new feature. label Oct 27, 2023
@David-Moreira
Copy link
Contributor

David-Moreira commented Nov 10, 2023

The DataGridAggregate requires Field to be the same Field as the Column you want to put it under currently. There is currently no way to customize the DataGridAggregate under the command and multi select columns.

image

I believe providing a CommandColumnTemplate and MultiSelectColumnTemplate under the DataGridAggregate might be appropriate. Would you also agree @stsrki ?

But for now, your best would be to allocate the Total string under the Id column for example.

@David-Moreira David-Moreira self-assigned this Nov 10, 2023
@David-Moreira David-Moreira added this to the Last Minute milestone Nov 10, 2023
@stsrki
Copy link
Collaborator

stsrki commented Nov 10, 2023

At the moment, when we define DataGridAggregate with the Field name, it automatically know to which Field/Column needs to be placed. Without the Field defined, it would be quite problematic to determine where we need to place the DataGridAggregate cell. So to overcome that limitation we would most probably have to have multiple DataGridAggregates to be able to place the aggregate cell under the desired column. To me that sounds a bit strange.

@David-Moreira
Copy link
Contributor

In this case I'm proposing two new templates for the command and multi select columns. Which is where the user is apparently trying to place the aggregate.

Nothing to do with DataGridAggregate and the Field. I think that should stay like that for now.

@stsrki
Copy link
Collaborator

stsrki commented Nov 10, 2023

I believe providing a CommandColumnTemplate and MultiSelectColumnTemplate under the DataGridAggregate might be appropriate. Would you also agree @stsrki ?

Yeah, but adding it under the DataGridAggregate would not make sense for the reasons I mentioned previously.

If we go the new template route, then I think adding it under the DataGridColumn(and other types) makes most sense. I would name it something along AggregateTemplate which would indicate by the naming where it would be placed. The AggregateTemplate would have the highest priority over the current DataGridAggregate rendering.

@David-Moreira
Copy link
Contributor

OH yes, that's what I meant haha. I didn't explain the api correctly I guess.

Yes, To have the AgreggateTemplate in the CommandColumn and MultiSelectColumn.

I guess the template is also a nice addition to the column either way, although it can be redudant since the aggregate already has the display template.

@stsrki
Copy link
Collaborator

stsrki commented Mar 8, 2024

@David-Moreira, easy win for the 1.5?

@David-Moreira
Copy link
Contributor

kk

@David-Moreira David-Moreira modified the milestones: Last Minute, 1.5 Mar 8, 2024
@David-Moreira David-Moreira linked a pull request Mar 8, 2024 that will close this issue
@stsrki stsrki mentioned this issue Mar 9, 2024
@stsrki stsrki moved this to ✔ Done in Development Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DataGrid Type: Feature ⚙ Request or idea for a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants