Python client & tests improvements #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
feat/apa/python_client_improvements
branch
2 times, most recently
from
1a57079
to
0478854
Compare
apaillier-ledger
force-pushed
the
feat/apa/python_client_improvements
branch
2 times, most recently
from
04b3cd2
to
816a179
Compare
- recover_message / recover_transaction - get_selector_from_data
Now uses the ERC 721/1155 ABIs, gets selector automatically, and actually verifies the signature
apaillier-ledger
force-pushed
the
feat/apa/python_client_improvements
branch
from
816a179
to
f5120ab
Compare
apaillier-ledger
force-pushed
the
feat/apa/python_client_improvements
branch
from
f5120ab
to
67a472d
Compare
fbeutin-ledger
approved these changes
Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now relies on the Web3.py library for tests.
Greatly simplifies both the tests client as well as the tests themselves.
Changes include