Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear testing using the updated client #123

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Clear testing using the updated client #123

merged 4 commits into from
Dec 5, 2023

Conversation

apaillier-ledger
Copy link
Contributor

Uses all the new things from LedgerHQ/app-ethereum#498 🎉

  • Now uses the proper test key to load the plugin (no more signature checks bypassing in the Ethereum app)
  • Now uses an ABI to handle the formatting of the transaction data (no more huge hardcoded raw hexadecimal payload)

fbeutin-ledger
fbeutin-ledger previously approved these changes Dec 1, 2023
View reviewed changes
@apaillier-ledger
Updated the ragger test to the new ethereum client
f1e5393
@apaillier-ledger
Removed superfluous assert on status words
ef2cfa3 
Will throw an exception anyway
@apaillier-ledger
Fix requirements file
9972339 
- ledgerwallet & web3.py had a protobuf conflict
- removed unused ones
@apaillier-ledger apaillier-ledger merged commit eb9fca7 into develop Dec 5, 2023
35 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/clear_testing branch December 5, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apaillier-ledger @fbeutin-ledger @tdejoigny-ledger