Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unset of user_id #52

Closed
wants to merge 1 commit into from
Closed

fix unset of user_id #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Mapper/UserHydrator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ public function hydrate(array $data, $object)
throw new Exception\InvalidArgumentException('$object must be an instance of LmcUser\Entity\UserInterface');
}

if (isset($data['user_id'])) {
$data = $this->mapField('user_id', 'id', $data);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this change fixes the warning, this is not the right place to make the change. If, for some reason, we needed to use the mapField() function with another key that does not exist in the data, we will get the warning again.
The change should be made in the mapField() function.

if (isset($array[$keyFrom])) {
  $array[$keyTo] = $array[$keyFrom];
  unset($array[$keyFrom];
}

return $array;


return $this->hydrator->hydrate($data, $object);
}
Expand Down