fix unset of user_id #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visto9259
requested changes
Mar 11, 2024
| $data = $this->mapField('user_id', 'id', $data); | ||
| } |
There was a problem hiding this comment.
Although this change fixes the warning, this is not the right place to make the change. If, for some reason, we needed to use the mapField() function with another key that does not exist in the data, we will get the warning again.
The change should be made in the mapField() function.
if (isset($array[$keyFrom])) {
$array[$keyTo] = $array[$keyFrom];
unset($array[$keyFrom];
}
return $array;
|
@vrkansagara Will you fix the PR as per my review comments? If not, I will fix it myself. |
|
I will fix it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue fixing for the #49 #51