Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove power on behaviour for Z111PL0H-1JX/Woolley SA-028 #8503

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Remove power on behaviour for Z111PL0H-1JX/Woolley SA-028 #8503

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733ba5a
Remove poweron behaviour for Z111PL0H-1JX/Woolley SA-028
kbullet Dec 22, 2024
d585bf4
Update model
kbullet Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/devices/sonoff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,13 +950,21 @@ const definitions: DefinitionWithExtend[] = [
exposes: [e.cover_position(), e.battery()],
},
{
zigbeeModel: ['Z111PL0H-1JX', 'SA-029-1', 'SA-028-1'],
zigbeeModel: ['SA-029-1', 'SA-028-1'],
model: 'SA-028/SA-029',
vendor: 'SONOFF',
whiteLabel: [{vendor: 'Woolley', model: 'SA-029-1'}],
description: 'Smart Plug',
extend: [onOff(), forcePowerSource({powerSource: 'Mains (single phase)'})],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to here instead, I guess the SA-029 and SA-028 also don't support it.

Copy link
Contributor Author

@kbullet kbullet Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Though seems like there are different versions/firmware of the SA-028 is being sold. One with power on behavior (SA-028 modelId) and one without (Z111PL0H-1JX) with exactly the same packaging and plug type.

Cant say for SA-029 since I don't have one on hand, it is suppose to be only a different socket type but then who knows what they decide to enable on the firmware 🙃
image

This is the db entry for the other SA-028 with power on behavior


{"id":117,"type":"Router","ieeeAddr":"0x7cb94c61881d0000","nwkAddr":22814,"manufId":4742,"manufName":"Sonoff","powerSource":"Mains (single phase)","modelId":"SA-028-1","epList":[1,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":9,"inClusterList":[0,3,4,5,6,4096,64599,64672],"outClusterList":[25],"clusters":{"genBasic":{"attributes":{"stackVersion":0,"hwVersion":0,"zclVersion":8}},"genOnOff":{"attributes":{"onOff":0,"startUpOnOff":255}}},"binds":[{"cluster":6,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1},{"cluster":25,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1}],"configuredReportings":[{"cluster":6,"attrId":0,"minRepIntval":0,"maxRepIntval":65000,"repChange":1}],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":1,"stackVersion":0,"hwVersion":0,"dateCode":"20210610-BL","swBuildId":"1.0.5","zclVersion":8,"interviewCompleted":true,"meta":{"configured":332242049},"lastSeen":1734895050344}

Anyhow I saw there's the S26R2ZB without power on behavior maybe I can move the Z111PL0H-1JX there as another SA-028 white label w/o pob? Instead of creating a completely new/separate model for this to pass the test Wdyt? And leave the SA-028/SA-029 as is.

},
{
zigbeeModel: ['Z111PL0H-1JX'],
model: 'SA-028/SA-029',
kbullet marked this conversation as resolved.
Show resolved Hide resolved
vendor: 'SONOFF',
whiteLabel: [{vendor: 'Woolley', model: 'SA-028-1'}],
description: 'Smart Plug',
extend: [onOff({powerOnBehavior: false}), forcePowerSource({powerSource: 'Mains (single phase)'})],
},
{
zigbeeModel: ['SNZB-01P'],
model: 'SNZB-01P',
Expand Down
Loading