Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove power on behaviour for Z111PL0H-1JX/Woolley SA-028 #8503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kbullet
Copy link
Contributor

@kbullet kbullet commented Dec 22, 2024

Got a couple more of these Woolley plugs, though seems like this batch I got with the model Z111PL0H-1JX identifier do not have power on behavior. (also mentioned by Koenkk/zigbee2mqtt#10282 (comment))

db entry:

{"id":122,"type":"Router","ieeeAddr":"0x00124b0025798705","nwkAddr":50011,"manufId":4742,"manufName":"SONOFF","powerSource":"Mains (single phase)","modelId":"Z111PL0H-1JX","epList":[1,13,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":256,"inClusterList":[0,3,4,5,6,64599,64672],"outClusterList":[25],"clusters":{"genOnOff":{"attributes":{"onOff":1}},"genBasic":{"attributes":{"modelId":"Z111PL0H-1JX","manufacturerName":"SONOFF","powerSource":1,"zclVersion":3,"hwVersion":1,"dateCode":"20211223","swBuildId":"1.0.1"}}},"binds":[{"cluster":6,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1},{"cluster":0,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1},{"cluster":25,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1}],"configuredReportings":[{"cluster":6,"attrId":0,"minRepIntval":0,"maxRepIntval":65000,"repChange":1}],"meta":{}},"13":{"profId":49246,"epId":13,"devId":57694,"inClusterList":[4096],"outClusterList":[4096],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"hwVersion":1,"dateCode":"20211223","swBuildId":"1.0.1","zclVersion":3,"interviewCompleted":true,"meta":{"configured":332242049},"lastSeen":1734876337875}

When trying to set power on behavior:

[2024-12-22 19:23:44] info: z2m:mqtt: MQTT publish: topic 'zigbee2mqtt/Outlet Living Room 2', payload '{"last_seen":"2024-12-22T19:23:44+07:00","linkquality":123,"power_on_behavior":null,"state":"ON"}'
[2024-12-22 19:23:44] error: z2m: Publish 'get' 'power_on_behavior' to 'Outlet Living Room 2' failed: 'Error: ZCL command 0x00124b0025798705/1 genOnOff.read(["startUpOnOff"], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"reservedBits":0,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'
[2024-12-22 19:23:47] info: z2m:mqtt: MQTT publish: topic 'zigbee2mqtt/Outlet Living Room 2', payload '{"last_seen":"2024-12-22T19:23:47+07:00","linkquality":123,"power_on_behavior":null,"state":"ON"}'
[2024-12-22 19:23:47] error: z2m: Publish 'set' 'power_on_behavior' to 'Outlet Living Room 2' failed: 'Error: Got UNSUPPORTED_ATTRIBUTE error, device does not support power on behaviour'

@@ -950,13 +950,21 @@ const definitions: DefinitionWithExtend[] = [
exposes: [e.cover_position(), e.battery()],
},
{
zigbeeModel: ['Z111PL0H-1JX', 'SA-029-1', 'SA-028-1'],
zigbeeModel: ['SA-029-1', 'SA-028-1'],
model: 'SA-028/SA-029',
vendor: 'SONOFF',
whiteLabel: [{vendor: 'Woolley', model: 'SA-029-1'}],
description: 'Smart Plug',
extend: [onOff(), forcePowerSource({powerSource: 'Mains (single phase)'})],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to here instead, I guess the SA-029 and SA-028 also don't support it.

Copy link
Contributor Author

@kbullet kbullet Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Though seems like there are different versions/firmware of the SA-028 is being sold. One with power on behavior (SA-028 modelId) and one without (Z111PL0H-1JX) with exactly the same packaging and plug type.

Cant say for SA-029 since I don't have one on hand, it is suppose to be only a different socket type but then who knows what they decide to enable on the firmware 🙃
image

This is the db entry for the other SA-028 with power on behavior


{"id":117,"type":"Router","ieeeAddr":"0x7cb94c61881d0000","nwkAddr":22814,"manufId":4742,"manufName":"Sonoff","powerSource":"Mains (single phase)","modelId":"SA-028-1","epList":[1,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":9,"inClusterList":[0,3,4,5,6,4096,64599,64672],"outClusterList":[25],"clusters":{"genBasic":{"attributes":{"stackVersion":0,"hwVersion":0,"zclVersion":8}},"genOnOff":{"attributes":{"onOff":0,"startUpOnOff":255}}},"binds":[{"cluster":6,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1},{"cluster":25,"type":"endpoint","deviceIeeeAddress":"0x00124b002f8b1364","endpointID":1}],"configuredReportings":[{"cluster":6,"attrId":0,"minRepIntval":0,"maxRepIntval":65000,"repChange":1}],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":1,"stackVersion":0,"hwVersion":0,"dateCode":"20210610-BL","swBuildId":"1.0.5","zclVersion":8,"interviewCompleted":true,"meta":{"configured":332242049},"lastSeen":1734895050344}

Anyhow I saw there's the S26R2ZB without power on behavior maybe I can move the Z111PL0H-1JX there as another SA-028 white label w/o pob? Instead of creating a completely new/separate model for this to pass the test Wdyt? And leave the SA-028/SA-029 as is.

src/devices/sonoff.ts Outdated Show resolved Hide resolved
Co-authored-by: Koen Kanters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants