Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning error details instead only the error message in group.errors #226

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Returning error details instead only the error message in group.errors #226

wants to merge 12 commits into from

Commits on Jun 27, 2012

  1. Validatable observables get an additional property errorDetails 

    which does not only contain the message but also the rule,
the params and the observable itself (to have access to it on grouping).
    delixfe committed Jun 27, 2012
    Configuration menu
    Copy the full SHA
    b28c958 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2012

  1. Added new option 'errorDetails' to grouping configuration. 

    If errorDetails is truthy then errorDetails objects are returned instead of plain error messages.
    delixfe committed Jun 28, 2012
    Configuration menu
    Copy the full SHA
    4bc55f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2012

  1. Merge branch 'master' into ErrorDetail 

    Conflicts:
	Src/knockout.validation.js
	Tests/validation-tests.js
    delixfe committed Aug 29, 2012
    Configuration menu
    Copy the full SHA
    52063bf View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2012

  1. Merge branch 'master' into ErrorDetail 

    Conflicts:
	Src/knockout.validation.js
    delixfe committed Aug 30, 2012
    Configuration menu
    Copy the full SHA
    26515f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2012

  1. ErrorDetails have to be enabled explictly via option 'enableErrorDeta… 

    …ils'
    delixfe committed Nov 23, 2012
    Configuration menu
    Copy the full SHA
    9b68bc2 View commit details
    Browse the repository at this point in the history

  2. enableErrorDetails was not checked correctly.

    delixfe committed Nov 23, 2012
    Configuration menu
    Copy the full SHA
    c00d1e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2012

  1. Changed the order in validateSync and validateAsync 

    because otherwise the call to observable.__valid__(isValid) triggers the reevaluation of computeds
before errorDetails is written.
    delixfe committed Nov 26, 2012
    Configuration menu
    Copy the full SHA
    e643e66 View commit details
    Browse the repository at this point in the history

  2. Added missing semicolon.

    delixfe committed Nov 26, 2012
    Configuration menu
    Copy the full SHA
    7bd7a10 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2012

  1. Merge branch 'master' into ErrorDetail

    delixfe committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    d9930df View commit details
    Browse the repository at this point in the history

  2. Fixed typo in comment.

    delixfe committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    3ad368f View commit details
    Browse the repository at this point in the history

  3. Properties of errorDetails are observable (except for observable). 

    To solve the problem of going from one invalid state to the next not updating lists bound to errorDetails.
    delixfe committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    f763c0c View commit details
    Browse the repository at this point in the history

  4. Dispose errorDetails properties.

    delixfe committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    e8cf78f View commit details
    Browse the repository at this point in the history